Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GHA workflows to fix CI #532

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Adjust GHA workflows to fix CI #532

merged 6 commits into from
Sep 24, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Sep 23, 2024

Description

Something changed in the way conda is activated on CI, so our Windows workaround stopped working. The easiest solution here (after trying to use Bash for Windows in #525) seems to be using the direct path to Python instead of relying on PATH via activation.

Changes:

  • Only install the test dependencies for conda-libmamba-solver if we are going to run the conda-libmamba-solver test suite. This is a no brainer, but it fixes a test in test_subcommands where conda-build was injecting its subcommands and they were not expected.
  • Switch Windows CLS tests to use bash too.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 23, 2024
@jaimergp jaimergp marked this pull request as ready for review September 24, 2024 10:48
@jezdez jezdez merged commit 05fcc0f into main Sep 24, 2024
63 checks passed
@jezdez jezdez deleted the fix-ci-2024-09 branch September 24, 2024 11:30
@jaimergp jaimergp added this to the 24.9 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

3 participants