Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After getting back from any click(link) , we should be on same position but we get to start of webpage #101

Open
knightmate opened this issue Jan 2, 2021 · 3 comments

Comments

@knightmate
Copy link

If we click on any project ,when we get back from that project link we get navigated at starting of webpage not on same project section.

@arpansac
Copy link
Contributor

arpansac commented Jan 3, 2021

This is going to be an interesting thing to solve!

@Ashwin-op
Copy link
Contributor

Maybe we can do something like,

During page unload, get the scroll position and store it in session storage (We should use session storage instead of local storage since session storge affects only the current tab while local storage shared between all tabs and windows of the same origin).

And this can be done per page (by appending pathname maybe?) so other pages in the same origin don't get affected.

@arpansac
Copy link
Contributor

arpansac commented Jan 8, 2021

Yup, I think that should be a smart way of doing it, since the complete page is loaded via ajax.
Plus since we have SSR enabled on the project, we could choose some of the request to be pre-loaded before the page is rendered.

As for the specific tab, I'm generating a unique app_id for every refresh that takes place (being sent from the server to front end), or we could find some unique id for that tab too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants