Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "method_count" issue in lib/variable/array-variable.js #103

Open
gregswindle opened this issue Sep 7, 2019 · 0 comments · May be fixed by #101
Open

Fix "method_count" issue in lib/variable/array-variable.js #103

gregswindle opened this issue Sep 7, 2019 · 0 comments · May be fixed by #101
Assignees
@gregswindle
Labels
priority: low Implement when there are no higher priority issues. status: accepted The proposal has community consensus. type: feedback Answers to questions or voluntary comments/suggestions. type: refactor Restructuring source code without changing its external behavior.
Projects
Product development
Milestone
Refactor modules ...

Comments

@gregswindle
Copy link
Contributor

ArrayVariable has 21 functions (exceeds 20 allowed). Consider refactoring.

https://codeclimate.com/github/commonality/archetypes-rules/lib/variable/array-variable.js#issue_5d731f1b477ced0001000072
@gregswindle gregswindle added status: review needed Needs community inspection or approval. type: feedback Answers to questions or voluntary comments/suggestions. labels Sep 7, 2019
@gregswindle gregswindle self-assigned this Sep 7, 2019
@gregswindle gregswindle added priority: low Implement when there are no higher priority issues. status: accepted The proposal has community consensus. type: refactor Restructuring source code without changing its external behavior. and removed status: review needed Needs community inspection or approval. labels Sep 7, 2019
@gregswindle gregswindle added this to To do in Product development via automation Sep 7, 2019
@gregswindle gregswindle linked a pull request Sep 7, 2019 that will close this issue
Open
3 tasks
gregswindle added a commit that referenced this issue Sep 7, 2019
@gregswindle
refactor(method-count): remove extra functions
c1e412f 
- Remove ArrayVariable.prototype.isNonEmpty
- Rename Proposition results' names to match their
  operator method names.

#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregswindle gregswindle

Labels
priority: low Implement when there are no higher priority issues. status: accepted The proposal has community consensus. type: feedback Answers to questions or voluntary comments/suggestions. type: refactor Restructuring source code without changing its external behavior.
Projects
Product development
  
To do
Milestone
Refactor modules with @sindresorhus.c...
Development

Successfully merging a pull request may close this issue.

refactor: evaluate RuleElements with @sindresorhus/ow#isValid commonality/archetypes-rules
1 participant
@gregswindle