-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error patching cpp when -review is used #344
Comments
UJAM-JH
changed the title
Error in patching cpp when -review is used
Error patching cpp when -review is used
Jul 19, 2022
thanks, eyeballing, looks like |
Is it possible this is a duplicate of #356? |
No, the files I ran comby on did not have any spaces in the path or filename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Comby fails on certain files if the -review option is used
Reproducing
save this as
comby.cpp
:and run this command:
DEBUG_COMBY=1 comby -review 'someFunc(:[1], :[2], :[3])' ':[1] = someOtherFunc(:[3], :[2])' comby.cpp
and then accept the change. Result:Expected behavior
It should patch after accepting the change
Additional context
comby 1.8.1, running on macOS.
Using the
-in-place
option works as expectedThe text was updated successfully, but these errors were encountered: