-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_repeated_merge_spill
fails with ValueError
#892
Comments
oh sorry, I saw #893 first and commented there. |
I believe I know what's going on here, but I'm not entirely sure on how to proceed. Here are the facts: I recently added a feature to package sync where it will try to determine the correct version of a package to use when people have multiple versions of the same package installed in their However, on Windows, trying to retrieve the list of files that were installed for the dask-labextension package raises a paths = (
(subdir / name)
.resolve()
.relative_to(self.locate_file('').resolve())
.as_posix()
for name in text.splitlines()
) Because dask-labextension uses jupyter-packaging to install data files outside of the I can try to work around this on the package sync side, but it's probably going to be hacky. |
This comment sure makes it sounds like jupyter-packaging is violating some standard about where files can be installed:
|
Actually, I'm going to call this an instance of python/importlib_metadata#455 |
I won't reopen but closing may be a mistake until the fix is actually deployed b/c Dask's CI will probably make new issues when this happens again. |
Yeah I'll keep an eye on those. |
FYI not certain when we'll deploy next. Probably this week but likely not
tomorrow morning.
We can deploy more urgently if you need us to but we haven't seen other
users hit by the bug so we're not feeling a ton of urgency (and we just
upgraded to Python 3.11 for the Coiled control plane and would prefer to
let that sit in staging a little longer than usual).
…On Wed, Jun 28, 2023 at 5:00 PM Irina Truong ***@***.***> wrote:
I won't reopen but closing may be a mistake until the fix is actually
deployed b/c Dask's CI will probably make new issues when this happens
again.
Yeah I'll keep an eye on those.
—
Reply to this email directly, view it on GitHub
<#892 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJKQRS2SJVYWEC2N3VZOIDXNSLNDANCNFSM6AAAAAAZWKMKPA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Deploy with intended fix just went out, |
Error looks like this:
ValueError: 'C:\\Miniconda3\\envs\\etc\\jupyter\\jupyter_notebook_config.d\\dask_labextension.json' is not in the subpath of 'C:\\Miniconda3\\envs\\test\\Lib\\site-packages' OR one path is relative and the other is absolute
Linked issue:
Full error:
The text was updated successfully, but these errors were encountered: