Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coil 3] Reconsider using androidx collection's LruCache(Or SieveCache) #2692

Open
revonateB0T opened this issue Nov 17, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@revonateB0T
Copy link
Contributor

revonateB0T commented Nov 17, 2024

Now that they added wasmJs & js target. https://developer.android.com/jetpack/androidx/releases/collection
We just wait a stable 1.5.0 .

@colinrtwhite colinrtwhite added the enhancement New feature or request label Nov 19, 2024
@colinrtwhite
Copy link
Member

Sounds good 👍🏻. Feel free to send over a PR once they hit stable. I think we can use SieveCache to replace all our LruCache and LruMap implementations.

@colinrtwhite
Copy link
Member

Took a quick look at this - it looks like LruCache and SieveCache only accept an Int as the max size, but we accept a Long in MemoryCache.Builder.maxSizeBytes. I think adopting these classes would mean dropping support for memory caches larger than Int.MAX_VALUE. which I'm not sure we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants