Loading network images in a RecyclerView

[Daniel-sims]

I have a screen where there's 8-9 items displayed at once, with an image associated with each item.

On slow networks if you enter the screen and scroll down at speed, occasionally the wrong images will be loaded into each item.

I'm using a load and a target to set the image drawable, I've added a call to dispose() before my call to load to dispose of the previous request and this seems to have fixed the bug.

But there's also the listener interface which we can use which sets the image for us. When implementing this, the images got completely out of sync with where they are, so I'm not sure if this is a bug or if we're meant to use target for situations like this.

with(imageView) {
    dispose()
    load(imageLink) {
        target(
            onSuccess = {
                // Show and hide some items
                .....
                imageView.setImageDrawable(it)
            }
        )
        size(size)
    }
}

Note that this bug was also happening before we migrated from Picasso to Coil, so I don't think the wrong images being loaded is specifically a Coil issue as we weren't calling cancelRequest either.

My questions;

• Do we need to call dispose in this scenario, or should load be doing this internally?
• What are the key differences between the listener and target interface implementations that cause behaviour like what I've described?