Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user about custom handler's tags potentially conflicting with default handlers #53

Open
simonacca opened this issue Feb 19, 2024 · 0 comments

Comments

@simonacca
Copy link

As a new user of transit, it wasn't obvious to me that default handler's tags share the same namespace as my custom tags.
It makes sense now, but hindsight is 20/20...

Ideally for me, a warning should be issued when trying to add a handler on a tag that already denotes another type, but the current "late binding" api doesn't seem amenable to this.

Instead, I would suggest adding a warning in the documentation of write-handler reminding the user to check for conflicts with previously declared tags (default or otherwise). Ideally pointing to the spec page on github where said default tags are easily visible.

Happy to contribute this if there's consensus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant