Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in activations (constraints and functions) #26

Open
carldlaird opened this issue Jan 16, 2022 · 0 comments
Open

Cleanup in activations (constraints and functions) #26

carldlaird opened this issue Jan 16, 2022 · 0 comments

Comments

@carldlaird
Copy link
Collaborator

There is some design work to do with the activation functions and constraints to gain more code reuse and expand the list of supported activations.

This issue originally came from a PR comment by @jalving.

add_constraint=True is not used here

net_block and net are also not used in activation methods. we should discuss whether we need them. they might be there for consistency on the calling side.

Originally posted by @jalving in #24 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant