feat(navbar-smooth-transition): added navbar-smooth-transition compo… #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudra-Sankha-Sinhamahapatra
had a problem deploying
to
preview-deployment
GitHub Actions
Failure
Rudra-Sankha-Sinhamahapatra
temporarily deployed
to
preview-deployment
GitHub Actions
Inactive
|
🚀 Preview deployed to: https://5170b2bf.animata.pages.dev |
|
@Rudra-Sankha-Sinhamahapatra The animation and responsiveness are not quite right. Could you check https://tedy.app and see how it works on mobile and desktop? Also, you can use shadcn's navigation menu for easier implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376
Screen.Recording.2024-10-26.at.6.43.56.PM.mov
I have kep the main div which's bg is white the height as 52 because if i dont keep it then you or i nobody will be able to see the dropdown menu its getting hidden then
(if any suggestions i am ready to change)
As you can see in the screen recording i havent used ripple button the reason is being that if i used the button then i cannot apply my own bg and hover bg then it acts weird and if i dont apply any className the size of it is so big so that it doesnt suits it
heres a few screenshots where you can clearly see how its working weird
so for this if you have any suggestions then i am ready to do these
Please review @hari @sudhashrestha