feat (#332) : added the list stack #360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansidhamne
temporarily deployed
to
preview-deployment
GitHub Actions
Inactive
|
🚀 Preview deployed to: https://1d2c58d3.animata.pages.dev |
hari
requested changes
Oct 15, 2024
Comment on lines
+82
to
+127
| <AnimatePresence> | ||
| {showAll | ||
| ? cards.map((card, index) => ( | ||
| <motion.div | ||
| key={card.id} | ||
| custom={index} | ||
| variants={revealAnimation} | ||
| initial="hidden" | ||
| animate="visible" | ||
| exit="hidden" | ||
| className="mb-3" | ||
| > | ||
| <CardStack | ||
| id={card.id} | ||
| icon={card.icon} | ||
| title={card.title} | ||
| location={card.location} | ||
| date={card.date} | ||
| /> | ||
| </motion.div> | ||
| )) | ||
| : cards.map((card, index) => ( | ||
| <motion.div | ||
| key={card.id} | ||
| custom={index} | ||
| variants={stackAnimation} | ||
| initial="hidden" | ||
| animate="visible" | ||
| exit="hidden" | ||
| style={{ | ||
| position: "absolute", | ||
| transformOrigin: "top center", | ||
| zIndex: cards.length - index, | ||
| }} | ||
| > | ||
| <CardStack | ||
| id={card.id} | ||
| icon={card.icon} | ||
| title={card.title} | ||
| location={card.location} | ||
| date={card.date} | ||
| /> | ||
| </motion.div> | ||
| ))} | ||
| </AnimatePresence> | ||
| </div> |
There was a problem hiding this comment.
You don't need the conditional rendering here. Just conditionally change the CSS style (transform).
Comment on lines
+137
to
+164
| {showAll ? ( | ||
| <> | ||
| <div className="flex flex-row items-center gap-1.5"> | ||
| <p>Hide</p> | ||
| <motion.div | ||
| initial={{ rotate: 0 }} | ||
| animate={{ rotate: 180 }} | ||
| transition={{ duration: 0.4 }} | ||
| > | ||
| <ChevronDown /> | ||
| </motion.div> | ||
| </div> | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <div className="flex flex-row items-center gap-1.5"> | ||
| <p>Show All</p> | ||
| <motion.div | ||
| initial={{ rotate: 0 }} | ||
| animate={{ rotate: 0 }} | ||
| transition={{ duration: 0.4 }} | ||
| > | ||
| <ChevronDown /> | ||
| </motion.div> | ||
| </div> | ||
| </> | ||
| )} | ||
| </motion.button> |
There was a problem hiding this comment.
Same here, you can conditionally change the text and the rotate property of the chevron, keeping the same elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video preview:
hack-2.mov
Do suggest any changes @hari
Closes #332