Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): add interactive nav bar #370

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

spartanns
Copy link

Closes #274

@hari
Copy link
Contributor

hari commented Oct 17, 2024

@spartanns Please push the related yarn.lock file as well, you have installed the dependency but yarn.lock is missing.

@hari hari self-requested a review October 17, 2024 13:49
@spartanns
Copy link
Author

Pushed.

@spartanns
Copy link
Author

It seems like I need to add the components/ui/navigation-menu.tsx... How do I do this? It's listed in .eslintignore, and if I remove it, the linter will fail.

@hari
Copy link
Contributor

hari commented Oct 21, 2024

@spartanns you can commit that using -n flag.

@spartanns spartanns temporarily deployed to preview-deployment October 21, 2024 04:13 — with GitHub Actions Inactive
@spartanns
Copy link
Author

Done.

Copy link

🚀 Preview deployed to: https://69856d8f.animata.pages.dev

@hari
Copy link
Contributor

hari commented Oct 21, 2024

@spartanns the colors are wrong in dark mode.

content/docs/container/interactive-nav-bar.mdx Outdated Show resolved Hide resolved
content/docs/container/interactive-nav-bar.mdx Outdated Show resolved Hide resolved
content/docs/container/interactive-nav-bar.mdx Outdated Show resolved Hide resolved
@spartanns spartanns temporarily deployed to preview-deployment October 21, 2024 16:01 — with GitHub Actions Inactive
@spartanns
Copy link
Author

Applied some fixes... Let me know if you want the carets from the nav buttons removed.

Copy link

🚀 Preview deployed to: https://3520c18a.animata.pages.dev

@hari
Copy link
Contributor

hari commented Oct 23, 2024

@spartanns I cannot interact with the items, if I move the mouse to the nav content, it closes. Also, if I click to open the item, it close as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive nav bar - 002
2 participants