Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pose_spherical function in clip_utils.py #33

Open
marcelsan opened this issue Aug 24, 2021 · 1 comment
Open

pose_spherical function in clip_utils.py #33

marcelsan opened this issue Aug 24, 2021 · 1 comment

Comments

@marcelsan
Copy link

marcelsan commented Aug 24, 2021

Hi @codestella and @riven314 ,

Thanks for the work on this repo! I just have a question about the function pose_spherical here. Specifically, it is not clear to me how you derive the C2W transformation from phi and theta. I don't understand what is the spherical coordinates system that you put in the comment of the function. Also what is the coordinate system of your NeRF? Is the OpenGL system?
Finally, what is the reasoning behind the matrix transformation: translation, followed by rot_phi, followed by rot_theta?

Thank you!

@mdda
Copy link

mdda commented May 24, 2022

One other quick question :

Why do you use rng_inputs[1] in each of the three dimensions?

https://github.com/codestella/putting-nerf-on-a-diet/blob/main/nerf/clip_utils.py#L148

It seems that the code should be more like:

    rng, *rng_inputs = jax.random.split(rng, 1+3)
    radius = random.uniform(rng_inputs[0], minval=bds[0], maxval=bds[1])
    theta = random.uniform(rng_inputs[1], minval=-jnp.pi, maxval=jnp.pi)
    phi = random.uniform(rng_inputs[2], minval=0, maxval=jnp.pi/2)
    return pose_spherical(radius, theta, phi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants