Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Semaphore CI provider #1485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add Semaphore CI provider #1485

wants to merge 1 commit into from

Conversation

benregn
Copy link

@benregn benregn commented Mar 19, 2024

Closes #1238 🙌

@benregn benregn requested a review from a team as a code owner March 19, 2024 08:02
@benregn benregn force-pushed the 1238-ci-support-semaphore-ci branch from 2270741 to 82e616e Compare March 19, 2024 08:32
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.61%. Comparing base (308e747) to head (14c7232).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   92.78%   92.61%   -0.17%     
==========================================
  Files          36       37       +1     
  Lines        1358     1395      +37     
  Branches      273      281       +8     
==========================================
+ Hits         1260     1292      +32     
- Misses         68       72       +4     
- Partials       30       31       +1
Flag Coverage Δ
aarch64 92.61% <94.59%> (+0.05%) ⬆️
aarch64-without-git 92.61% <94.59%> (+0.05%) ⬆️
alpine 92.61% <94.59%> (-0.17%) ⬇️
alpine-proxy 92.61% <94.59%> (+0.05%) ⬆️
alpine-without-git 92.61% <94.59%> (-0.17%) ⬇️
linux 92.61% <94.59%> (+0.05%) ⬆️
linux-without-git 92.61% <94.59%> (+0.05%) ⬆️
macos 92.61% <94.59%> (+0.05%) ⬆️
macos-without-git 92.61% <94.59%> (+0.05%) ⬆️
windows 92.61% <94.59%> (-0.17%) ⬇️
windows-without-git ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ci_providers/index.ts 100.00% <100.00%> (ø)
src/ci_providers/provider_semaphore.ts 94.44% <94.44%> (ø)

... and 1 file with indirect coverage changes

thomasrockhu-codecov
thomasrockhu-codecov requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @benregn! Just some changes. Do you also have a semaphore CI run to run this off of?

src/ci_providers/provider_semaphore.ts Outdated Show resolved Hide resolved
src/ci_providers/provider_semaphore.ts Outdated Show resolved Hide resolved
@benregn benregn force-pushed the 1238-ci-support-semaphore-ci branch from 82e616e to 14c7232 Compare March 23, 2024 12:29
@benregn
Copy link
Author

benregn commented Mar 23, 2024 •
edited

@thomasrockhu-codecov Thank you for the feedback! Overlooked that those lines weren't needed anymore 🤦

We're using Semaphore at my place of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasrockhu-codecov thomasrockhu-codecov Awaiting requested review from thomasrockhu-codecov

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Support: SemaphoreCI
2 participants
@benregn @thomasrockhu-codecov