Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Support: SemaphoreCI #1238

Open
drazisil-codecov opened this issue Oct 17, 2023 · 0 comments · May be fixed by #1485
Open

CI Support: SemaphoreCI #1238

drazisil-codecov opened this issue Oct 17, 2023 · 0 comments · May be fixed by #1485
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest approved

Comments

@drazisil-codecov
Copy link
Contributor

drazisil-codecov commented Oct 17, 2023 •
edited

I never expected the Git SHA's from SemaphoreCI to be different
than the PR. The issue was the uploader using the SEMAPHORE_GIT_SHA
(which is a non-existent SHA as you pointed out) instead of
SEMAPHORE_GIT_PR_SHA. So I resolved the issue by forcing the uploader
to use the "-C" CLI arg.

This can be done by following the directions here https://github.com/codecov/uploader/blob/24772d18bd16800d9f57ed3a01c29b6f21a2317a/CONTRIBUTING.md#adding-a-new-ci-provider

This is already supported in the API https://github.com/codecov/codecov-api/blob/4c595ac7c74d496ac5f6fd440a93a00c6546cb1f/upload/constants.py#L142-L147 so no changes where be needed there. The "service" query value will need to match semaphore
@drazisil-codecov drazisil-codecov added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest approved labels Oct 17, 2023
@benregn benregn linked a pull request Mar 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Semaphore CI provider benregn/codecov-uploader
1 participant
@drazisil-codecov