Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload failed: {"detail":"Not valid tokenless upload"} #81

Open
ssbarnea opened this issue Aug 15, 2024 · 0 comments
Open

Upload failed: {"detail":"Not valid tokenless upload"} #81

ssbarnea opened this issue Aug 15, 2024 · 0 comments

Comments

@ssbarnea
Copy link

As opposed to its older sibling https://github.com/codecov/codecov-action this action does not support use_oidc flag.

The issue here is that this happening on pull requests coming from external forks, triggered on pull_request, so they do not have access to the environment secrets.

Changing the workflow definition to trigger on pull_request_target would prevent us from testing genuine pull requests that are fixing GHA workflows themselves. A bit of a chicken and the egg kind of issue.

Should I maybe upload test results only for jobs triggered on pushes and avoid running them for pull-requests?

PS. In fact I am wondering why this action was developed separately instead of just extending codecov/codecov-action to also allow upload of test results. It would have being much easier from many points of view, including addressing the authentication challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant