Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We show both carried forward and uploaded sessions per flag in the uploads list #352

Closed
drazisil-codecov opened this issue Apr 25, 2024 · 7 comments
Assignees
Labels
Bug For issues and unexpected behaviors

Comments

@drazisil-codecov
Copy link

Describe the bug
We show both carried forward and uploaded sessions per flag in the uploads list

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://app.codecov.io/gh/rustymotors/server/commit/3e76d6f676cba99b6ba9a849bb232c0c5f82a2aa
  2. View upload list

Expected behavior
No carried forward entries for a flag that coverage was uploaded for on that commit.

@thomasrockhu-codecov
Copy link
Contributor

image

To be clear, I think it's showing both (as an example) the login flag, but also that it's being carried forward which seems conflicting.

@rohan-at-sentry rohan-at-sentry removed their assignment May 8, 2024
@aj-codecov
Copy link
Member

@drazisil-codecov I believe we spoke about this one and it should be a bug that we fix as I believe it's a regression. Did it make it into a bug sync/get assigned out at some point?

@drazisil-codecov
Copy link
Author

@aj-codecov I was on vacation last week so I don't know. If not then it will be handled in next week's sync, assuming it's not assigned to anyone show it shows up :)

@drazisil-codecov drazisil-codecov added the Bug For issues and unexpected behaviors label May 8, 2024
@drazisil-codecov drazisil-codecov removed their assignment May 8, 2024
@trent-codecov
Copy link

@trent-codecov
Copy link

The issue seems to be that it is duplicating the CF sessions on every upload. Plenty of details on the ticket linked.

@adrian-codecov
Copy link

This is a bug on our end and not linked to the potential duplication with CF sessions as pointed above. PR for fix is in

@adrian-codecov
Copy link

This is fixed - check the link in the original description to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For issues and unexpected behaviors
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

6 participants