Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move YAML validation logic to within the CLI #491

Open
rohan-at-sentry opened this issue Aug 27, 2024 · 1 comment
Open

Move YAML validation logic to within the CLI #491

rohan-at-sentry opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
Area: General UX Issues with general UX enhancement New feature or request Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@rohan-at-sentry
Copy link
Contributor

There shouldn't be a need to make a network request to validate the YAML - we can likely do this within the CLI itself now, as it's no longer in bash. We don't really provide a way to communicate if a config is invalid, this is a step in that direction.

@rohan-at-sentry rohan-at-sentry added Area: General UX Issues with general UX enhancement New feature or request Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months labels Aug 27, 2024
@nicholas-codecov
Copy link
Contributor

If we're removing the ability to validate the YAML via an endpoint can you also make sure that we remove that copy from the UI. In the repo settings we have a snippet telling people how to validate their YAML.

Image

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: General UX Issues with general UX enhancement New feature or request Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

3 participants