Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload not processed #1633

Closed
greg0ire opened this issue Nov 4, 2024 · 21 comments
Closed

Upload not processed #1633

greg0ire opened this issue Nov 4, 2024 · 21 comments
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@greg0ire
Copy link

greg0ire commented Nov 4, 2024

I have a repository with Github Actions and Appveyor.
Github actions sends one upload with many reports, and Appveyor sends 3 uploads.
When the pull request is sent from a fork, the github action upload is seemingly not processed. The Appveyor reports uploads are processed.

For example, if we look at this PR

What are we doing wrong? The upload action is defined here: https://github.com/doctrine/dbal/blob/604277ebebdaf462ff4173b40ddf85dc80d63398/.github/workflows/continuous-integration.yml#L624-L658

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Nov 4, 2024
@thomasrockhu-codecov thomasrockhu-codecov added Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months Area: Report Upload Issues with pre-ingest report uploading labels Nov 5, 2024
@thomasrockhu-codecov
Copy link
Contributor

@greg0ire I'm seeing some errors and asking our product team why that might be. Are you a member of the doctrine org btw? I don't think it's related, but just in case.

@greg0ire
Copy link
Author

Yes, I'm a member of that organization.

@greg0ire
Copy link
Author

Noteworthy: after upgrading to v5 of the action, there was a working run: doctrine/dbal#6613

Let us see if we can keep this up.

@thomasrockhu-codecov
Copy link
Contributor

@greg0ire 🤞 let me know if it is not working. I just pushed a new version which I had expected to fix this issue.

@greg0ire
Copy link
Author

Ok, let's close then, I'll reopen if something is wrong 🤞

@greg0ire greg0ire reopened this Nov 20, 2024
@greg0ire
Copy link
Author

Well… something is wrong. Now, all our branches use v5, and on this PR, which existed before the change but has received new commits since it, we can see a successful upload.

The action links to https://app.codecov.io/github/doctrine/dbal/commit/402c6e396ce33920b99aa644eccc54f58f6f5ad3, where we can only see 2 reports from appveyor when there should be 3 of them with the github action report.

The page does not indicate that the github action is being processed or anything like that.

@thomasrockhu-codecov
Copy link
Contributor

@greg0ire yeah I have a suspicion that there was a bug, can you try the latest and see if that fixes the issue?

@greg0ire
Copy link
Author

The person has rebased their PR, and it worked. Let's close again since you're saying that was temporary.

@greg0ire greg0ire reopened this Nov 21, 2024
@greg0ire
Copy link
Author

@thomasrockhu-codecov there was another push, and another failure, can you take a look?

@thomasrockhu-codecov
Copy link
Contributor

@greg0ire yeah, can you link me CI?

@greg0ire
Copy link
Author

greg0ire commented Nov 21, 2024

Sure, here you go

EDIT: I'm currently retrying it right now (22:36 UTC), I'm curious to see if it's possible to have a success for the very same commit.
EDIT: Does not seem to work better, I'll try a third time (22:50 UTC).
EDIT: Not working either. Not sure what you can deduce from that…

Is there maybe a timeframe during which reports must be submitted?

@thomasrockhu-codecov
Copy link
Contributor

@greg0ire just so I'm clear, this is what I'm seeing

  1. From CI side, it looks like attempt 3-6 were successful in queueing an upload to Codecov
  2. On Codecov UI, I only see Appveyor uploads on the commit f625999.
  3. I am seeing some errors on our side that I'm going to try to dig into

@drazisil-codecov
Copy link
Contributor

Hi @greg0ire

Tom is out for a bit, and asked me to take a look.

Token of length 0 detected

Are you using a token with GitHub actions? Or so, it seems to be being passed incorrectly. If not, could you please try adding it an see if that works? The uploads were rejected due to no access.

@greg0ire
Copy link
Author

@drazisil-codecov there are PR from forks so these are tokenless uploads. The action shows that it understands that: https://github.com/doctrine/dbal/actions/runs/11949420933/job/33340420372?pr=6596#step:5:79

Fork detected, tokenless uploading used

When the pull request is not created from a fork, then these 2 lines should result in the token being provided: https://github.com/doctrine/dbal/blob/4.2.x/.github/workflows/continuous-integration.yml#L637-L638

When the pull request is created from a fork, I guess there is an empty env variable, and the action should IMO be fine with it, and not forward an empty token to the server since it detected this is going to be a tokenless upload.

@drazisil-codecov
Copy link
Contributor

drazisil-codecov commented Nov 25, 2024

Unauthorized: /upload/github/doctrine::::dbal/commits/f625999a6963e582e0ecb05706a63d55bd20893e/reports/default/uploads

@rohan-at-sentry in this case, would this be in error?

Image

@drazisil-codecov
Copy link
Contributor

Hi @greg0ire It looks like @alcaeus configured Codecov to require tokens for forks.

@greg0ire
Copy link
Author

@drazisil-codecov sorry, do you know at which level they would have done that?

@drazisil-codecov
Copy link
Contributor

Hi @greg0ire

I don't have access, but I believe the URL would be https://app.codecov.io/accoint/github/doctrine/org-upload-token

Only org admins can access that page.

@greg0ire
Copy link
Author

Thank you, Andreas told me he just changed that settings, let us see how it behaves on the next pull requests 🤞

@greg0ire
Copy link
Author

greg0ire commented Nov 27, 2024

I'll close when it works for all builds of 3 different PRs. I will list them here

  1. Add CTE support to select in QueryBuilder doctrine/dbal#6621
  2. Fix unwanted SQLite schema emulation in SqliteSchemaManager doctrine/dbal#6337
  3. Add support for Postgres positional parameters to Parser doctrine/dbal#6634

@greg0ire
Copy link
Author

greg0ire commented Dec 3, 2024

It appears to be working! Thank you!

@greg0ire greg0ire closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

3 participants