Upload not processed

[greg0ire]

I have a repository with Github Actions and Appveyor.
Github actions sends one upload with many reports, and Appveyor sends 3 uploads.
When the pull request is sent from a fork, the github action upload is seemingly not processed. The Appveyor reports uploads are processed.

For example, if we look at this PR

• The Github action is successful
• The UI only shows the appveyor reports.
• After merging, another build happens, this time not on the fork
• Codecov successfully receives all uploads

What are we doing wrong? The upload action is defined here: https://github.com/doctrine/dbal/blob/604277ebebdaf462ff4173b40ddf85dc80d63398/.github/workflows/continuous-integration.yml#L624-L658

[thomasrockhu-codecov]

@greg0ire I'm seeing some errors and asking our product team why that might be. Are you a member of the doctrine org btw? I don't think it's related, but just in case.

[greg0ire]

Yes, I'm a member of that organization.

[greg0ire]

Noteworthy: after upgrading to v5 of the action, there was a working run: doctrine/dbal#6613

Let us see if we can keep this up.

[thomasrockhu-codecov]

@greg0ire 🤞 let me know if it is not working. I just pushed a new version which I had expected to fix this issue.

[greg0ire]

Ok, let's close then, I'll reopen if something is wrong 🤞

[greg0ire]

Well… something is wrong. Now, all our branches use v5, and on this PR, which existed before the change but has received new commits since it, we can see a successful upload.

The action links to https://app.codecov.io/github/doctrine/dbal/commit/402c6e396ce33920b99aa644eccc54f58f6f5ad3, where we can only see 2 reports from appveyor when there should be 3 of them with the github action report.

The page does not indicate that the github action is being processed or anything like that.

[thomasrockhu-codecov]

@greg0ire yeah I have a suspicion that there was a bug, can you try the latest and see if that fixes the issue?

[greg0ire]

The person has rebased their PR, and it worked. Let's close again since you're saying that was temporary.

[greg0ire]

@thomasrockhu-codecov there was another push, and another failure, can you take a look?

[thomasrockhu-codecov]

@greg0ire yeah, can you link me CI?

[greg0ire]

Sure, here you go

EDIT: I'm currently retrying it right now (22:36 UTC), I'm curious to see if it's possible to have a success for the very same commit.
EDIT: Does not seem to work better, I'll try a third time (22:50 UTC).
EDIT: Not working either. Not sure what you can deduce from that…

Is there maybe a timeframe during which reports must be submitted?

[thomasrockhu-codecov]

@greg0ire just so I'm clear, this is what I'm seeing

1. From CI side, it looks like attempt 3-6 were successful in queueing an upload to Codecov
2. On Codecov UI, I only see Appveyor uploads on the commit f625999.
3. I am seeing some errors on our side that I'm going to try to dig into

[drazisil-codecov]

Hi @greg0ire

Tom is out for a bit, and asked me to take a look.

Token of length 0 detected

Are you using a token with GitHub actions? Or so, it seems to be being passed incorrectly. If not, could you please try adding it an see if that works? The uploads were rejected due to no access.

[greg0ire]

@drazisil-codecov there are PR from forks so these are tokenless uploads. The action shows that it understands that: https://github.com/doctrine/dbal/actions/runs/11949420933/job/33340420372?pr=6596#step:5:79

Fork detected, tokenless uploading used

When the pull request is not created from a fork, then these 2 lines should result in the token being provided: https://github.com/doctrine/dbal/blob/4.2.x/.github/workflows/continuous-integration.yml#L637-L638

When the pull request is created from a fork, I guess there is an empty env variable, and the action should IMO be fine with it, and not forward an empty token to the server since it detected this is going to be a tokenless upload.

[drazisil-codecov]

Unauthorized: /upload/github/doctrine::::dbal/commits/f625999a6963e582e0ecb05706a63d55bd20893e/reports/default/uploads

@rohan-at-sentry in this case, would this be in error?

[drazisil-codecov]

Hi @greg0ire It looks like @alcaeus configured Codecov to require tokens for forks.

[greg0ire]

@drazisil-codecov sorry, do you know at which level they would have done that?

[drazisil-codecov]

Hi @greg0ire

I don't have access, but I believe the URL would be https://app.codecov.io/accoint/github/doctrine/org-upload-token

Only org admins can access that page.

[greg0ire]

Thank you, Andreas told me he just changed that settings, let us see how it behaves on the next pull requests 🤞

[greg0ire]

I'll close when it works for all builds of 3 different PRs. I will list them here

1. Add CTE support to select in QueryBuilder doctrine/dbal#6621
2. Fix unwanted SQLite schema emulation in SqliteSchemaManager doctrine/dbal#6337
3. Add support for Postgres positional parameters to Parser doctrine/dbal#6634

[greg0ire]

It appears to be working! Thank you!