-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploads throttled while using token-based upload from public repo #1568
Comments
I am seeing the same problem, with a public repository and a valid token defined:
Setup: - name: "Upload to Codecov"
uses: "codecov/codecov-action@v4"
if: env.CODECOV_TOKEN != null
with:
token: ${{ env.CODECOV_TOKEN }}
files: ./build/reports/jacoco/jacocoRootReport/jacocoRootReport.xml
flags: ${{ matrix.category }}
name: ${{ matrix.category }}
verbose: true |
Same error:
Minimal GHA workflow:
|
We have this same problem (CI for a push will upload to codecov but ci for a pull requests will not). I noticed that in the "Setup" part of the log (very top) the push job has
but the pull request job has
I think this means the token is indeed not made available. I'm not sure how to work around this, nor why this is not an issue for everyone. |
@adcroft, see documentation for pull_request and secret access https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflows-in-forked-repositories If you change your trigger to |
@mattwthompson @mmoayyed @pete-resim @adcroft @AndreKurait apologies, there's a lot going on in this thread. I would suggest
Those are likely the things that will fix it fastest. Please let me know if those don't work, and we can dig through and see what's going on. |
Here's the relevant snippet from a log:
Things I've thought about:
main
branch nightly. This results in many uploads from the same commit, which has been throttled in the past. However, this was previously made clear in the error and all I'm seeing here is a non-descript failure and exit code 1.@v4
in the action, which is the latest major version, but I'm pretty sure that's suposed to bring down the latest 4.x.x anyway.coverage
in its name? It's a notebook and obviously not storing code coverage data, but that file has been there for years without issue. I couldexclude:
it, but I'm already specifyingfile: coverage.xml
so it's surprising that it's even looking elsewhere ... ?coverage.py
is indeed not installed - but a package namedcoverage
is, andpytest
ran with a bunch of coverage-related options. I'd expect this to be a problem if the coverage report wasn't generated, but I think it is being generated.The text was updated successfully, but these errors were encountered: