Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not valid tokenless upload #1487

Closed
greg0ire opened this issue Jun 18, 2024 · 29 comments
Closed

Not valid tokenless upload #1487

greg0ire opened this issue Jun 18, 2024 · 29 comments
Assignees
Labels
bug Something isn't working

Comments

@greg0ire
Copy link

I believe this has been happening for a few weeks now, but many of our PRs using tokenless upload (they are PRs from open source forks) fail with Report creating failed: {"detail":"Not valid tokenless upload"}

Here is an example: https://github.com/doctrine/dbal/actions/runs/9554014292/job/26334506168

@thomasrockhu-codecov
Copy link
Contributor

@joseph-sentry do you mind taking a look here?

@joseph-sentry
Copy link
Contributor

@thomasrockhu-codecov since we made the API changes for the new tokenless, unless a user is using the updated CLI (which hasn't been released yet) and the updated action, tokenless won't work

@ybiquitous
Copy link

ybiquitous commented Jun 20, 2024

Hi, I encounter a similar issue.

The new CLI version was released recently (https://github.com/codecov/codecov-cli/releases/tag/v0.7.0), but my problem still occurs.

Here's the failed log of a fork PR in the stylelint repo (stylelint/stylelint#7777):

==> Fork detected, tokenless uploading used

at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:16

==> Running version v0.7.0

at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:33

Error: Codecov token not found. Please provide Codecov token with -t flag.

at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:44

It would be great if you could help. Thanks. 🙏🏼

@ybiquitous
Copy link

In addition, here's a successful log with the CLI v0.6.0:

==> Running version v0.6.0

at https://github.com/stylelint/stylelint/actions/runs/9601142978/job/26479023288?pr=7776#step:7:33

@qweeah
Copy link

qweeah commented Jun 21, 2024

Looks like this is introduced by the Codecov CLI v0.7.0. Since the GPG SUM of v0.6.0 does not exist any more, is it possible to reset the Codecov CLI back to 0.6.0 without checking the GPG sum? Downgrade CLI to v0.6.0 works.

@bdrung
Copy link

bdrung commented Jun 21, 2024

We have the same issue with Apport. Example failed upload: https://github.com/canonical/apport/actions/runs/9506858733/job/26508430770?pr=355

lbianchi-lbl added a commit to lbianchi-lbl/parameter-sweep that referenced this issue Jun 21, 2024
lbianchi-lbl added a commit to watertap-org/parameter-sweep that referenced this issue Jun 21, 2024
* Remove WaterTAP-specific how-to pages

* Move existing files

* Add core files for Sphinx docs

* Add minimal installation instructions

* Add ReadTheDocs config file

* Reformat with Black

* Add basic GHA check for docs build

* Try resolving failures for Python 3.8

* Try fixing Codecov upload error

* Try fixing workflow syntax error

* Try with space

* Try downgrading Codecov CLI due to codecov/codecov-action#1487
lbianchi-lbl added a commit to lbianchi-lbl/watertap that referenced this issue Jun 21, 2024
lbianchi-lbl added a commit to lbianchi-lbl/watertap that referenced this issue Jun 21, 2024
lbianchi-lbl added a commit to watertap-org/watertap that referenced this issue Jun 21, 2024
* Empty commit to test codecov/codecov-action#1487

* Specify Codecov CLI version to work around codecov/codecov-action#1487

* Add Codecov fix to MPI workflow

Even though it'll be removed as part of #1345
lbianchi-lbl added a commit to lbianchi-lbl/idaes-pse that referenced this issue Jun 21, 2024
@joseph-sentry
Copy link
Contributor

Hi all, indeed tokenless uploads were broken for v0.7.0 of the CLI, we just released v0.7.1 which should fix that bug. If you've already versioned to v0.6.0, that should work fine as well.

@ybiquitous
Copy link

@joseph-sentry Thanks for the quick patch! I'll try it soon. 👍🏼

By the way, the release notes and the changelog link seem incorrect to me in https://github.com/codecov/codecov-cli/releases/tag/v0.7.1 because of too many items. 👀

@ybiquitous
Copy link

ybiquitous commented Jun 21, 2024

@joseph-sentry Unfortunately, the problem doesn't seem to be resolved. 😢

Error: Codecov token not found. Please provide Codecov token with -t flag.

https://github.com/stylelint/stylelint/actions/runs/9617068584/job/26528019385?pr=7783#step:7:44

PR: stylelint/stylelint#7783


EDIT: I confirmed v0.7.1 was used:

==> Running version v0.7.1

https://github.com/stylelint/stylelint/actions/runs/9617068584/job/26528019385?pr=7783#step:7:33

@thomasrockhu-codecov
Copy link
Contributor

@ybiquitous would you mind trying to re-run again? I think this may have just been a caching thing on our side

@qweeah
Copy link

qweeah commented Jul 1, 2024

@thomasrockhu-codecov Switched to v0.7.2 and the upload is successful, thank you all for the quick response.

@mrmundt
Copy link

mrmundt commented Jul 1, 2024

@aravinda0
Copy link

I'm stuck on this as well. Specifying the v0.6.0 downgrade doesn't solve it. I still get:

Commit creating failed: {"detail":"Not valid tokenless upload"}

Here's the failing job: https://github.com/aravinda0/qtile-bonsai/actions/runs/9873228232/job/27272344047

@mrmundt
Copy link

mrmundt commented Jul 10, 2024

In case this helps anyone else: our (Pyomo) problem was that we upload from multiple sources (GHA, Jenkins), and the uploader used on Jenkins was outdated / causing issues. Once we switched to a the codecov-cli uploader, our problems were resolved.

@derrix060
Copy link

derrix060 commented Jul 12, 2024

Also failing for me: https://github.com/NethermindEth/juno/actions/runs/9870665136/job/27256902195

It doesn't even detect that it's a forked repo, am I missing anything??

Edit: It turns out I was using an older version, v4.2.0. Updating it to the latest v4.5.0 fixed the problem.

ksbeattie added a commit to IDAES/idaes-pse that referenced this issue Jul 18, 2024
…1441)

* Specify Codecov version to work around codecov/codecov-action#1487

* Try with v0.7.1

---------

Co-authored-by: Keith Beattie <[email protected]>
@trent-codecov
Copy link

This issue has been patched. Please open a new issue if problems arise.

@greg0ire
Copy link
Author

@trent-codecov I'm still experiencing the issue, and I'm not sure what I need to upgrade in order to obtain the patch, if it has been released. I see the latest tag on this repo is from June, but maybe the fix was contributed in a dependency?

@thomasrockhu-codecov
Copy link
Contributor

@greg0ire I think you need to remove the double-quotes from this line

@greg0ire
Copy link
Author

@thomasrockhu-codecov that line is not used at all when using tokenless upload, is it?

As you can see, that line does it job when the upload is not tokenless

@greg0ire
Copy link
Author

@thomasrockhu-codecov sorry for doubting you, the fix you suggested appears to work: doctrine/dbal#6501

I don't understand why, could you please explain?

@thomasrockhu-codecov
Copy link
Contributor

@greg0ire I actually need to dig in and figure it out for myself, but it smelled like an empty string vs null value thing. I would assume somewhere (probably CLI), we take "" to mean you want to use that as the token. That's probably a bug on our side, but I wanted to unblock you quickly.

@greg0ire
Copy link
Author

Thank you! null vs string does make sense, since the secret is probably null in the case of a fork 👍

@greg0ire
Copy link
Author

@thomasrockhu-codecov I'm sad to say that this job failed with the infamous "Not valid tokenless upload". It contains my commit that removes the quotes, I checked.

@thomasrockhu-codecov
Copy link
Contributor

@greg0ire just checking, was this during our outage?

@greg0ire
Copy link
Author

I don't think so, your outage was marked as resolved on Aug 17, 2024 - 03:58 UTC , and the job failed later the same day at 11:46 GMT+2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants