Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using a pre-installed codecov binary #1268

Open
veehaitch opened this issue Feb 5, 2024 · 5 comments
Open

Support using a pre-installed codecov binary #1268

veehaitch opened this issue Feb 5, 2024 · 5 comments
Assignees

Comments

@veehaitch
Copy link

Currently, the action always downloads the codecov-cli binary:

https.get(getBaseUrl(platform, uploaderVersion), (res) => {

This causes trouble in some environments where networking access is restricted (also see #700) or if the action should use a specific version of the binary (e.g., an audited version built from source).

Adding a new argument to action.yml which allows giving an absolute path to the binary would be very helpful.

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Feb 5, 2024
@thomasrockhu-codecov
Copy link
Contributor

@veehaitch this is a great idea. I'm a little bit slammed at the moment, but I will work on adding this in sometime this month

@veehaitch
Copy link
Author

Any update on this, @thomasrockhu-codecov? 🙂

@thomasrockhu-codecov
Copy link
Contributor

@veehaitch gah, time really has caught up to me. Let me see what I can do this week, thanks for following up @veehaitch

@veehaitch
Copy link
Author

Great, thanks for the quick response!

@thomasrockhu-codecov
Copy link
Contributor

@veehaitch I haven't forgotten about this, we are considering a different architecture to the action that may make this easier to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants