Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace buttons by tab component #344

Open
mfranzke opened this issue Apr 4, 2023 · 2 comments
Open

Replace buttons by tab component #344

mfranzke opened this issue Apr 4, 2023 · 2 comments

Comments

@mfranzke
Copy link
Contributor

mfranzke commented Apr 4, 2023

          Just a passing suggestion (maybe not something to implement here in this PR, but just a thought).

I would maybe suggest using an accessible UI foundation package for the editor (which is essentially a Tabs component, I think?). There are quite a few keyboard interactions (e.g. roving focus) that are a bit tricky to get right when rolling your own.

For comparison's sake, here are a few that I know of, off the top of my head:

Originally posted by @melanieseltzer in #341 (comment)

@melanieseltzer
Copy link

melanieseltzer commented Apr 4, 2023

Thanks for opening this and surfacing my suggestion @mfranzke 👍

@pomber I would be happy to help work on implementation if you are open to it.

@stern-shawn
Copy link

+1 for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants