Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Search box hotkey not working with transcript enabled #2731

Open
WilliamGoodman opened this issue Dec 15, 2024 · 1 comment
Open

🐞 Search box hotkey not working with transcript enabled #2731

WilliamGoodman opened this issue Dec 15, 2024 · 1 comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@WilliamGoodman
Copy link

Concise Description

Go to search box functionality not working when transcript option is enabled

Browser/s

Chrome, Edge

Other Browser:

No response

'Steps to reproduce' - Which of our features is required for the bug to happen?

Enable transcript option in Appearance -> Sidebar. Load YouTube video, then "Go to search box" hotkey no longer works

Since when?

Unknown

Does the bug still happen when you log out of YouTube?

Yes

..No? Then please paste your yt.config_.EXPERIMENT_FLAGS. Twice (With the error & Without)

No response

Are any errors or related log-messages shown in the Browser-Console? (F12)

No response

Tested as the only active extension? (incognito mode or another browser users):

None

Expected preferred behavior:

No response

ImprovedTube Version

No response

Your Settings (From the Extension's -Hamburger menu > Settings > Backup & reset > Export settings)

No response

Your YouTube-Document

No response

OS / Device:

No response

@WilliamGoodman WilliamGoodman added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Dec 15, 2024
@WilliamGoodman WilliamGoodman changed the title 🐞 🐞 Search box hotkey not working with transcript enabled Dec 15, 2024
ImprovedTube added a commit that referenced this issue Dec 15, 2024
@ImprovedTube
Copy link
Member

hi and thanks @WilliamGoodman
i recently had to forbid youtube from scrolling (focusing) for 2s when we expand description or transcript

ImprovedTube.forbidFocus(2100);
const descriptionTranscript = el.querySelector('ytd-video-description-transcript-section-renderer button[aria-label]');
descriptionTranscript ? descriptionTranscript.click() : el.querySelector('[target-id*=transcript]')?.removeAttribute('visibility');
(i think it could be more specific at click or in only one of the two cases)

so i just made the shortcut, cut these 2s short.
alternatively (simpler) the shortcut could "click()" instead of "focus()"

you can test the change already downloading the repo https://github.com/code-for-charity/ImprovedTube-for-YouTube/archive/refs/heads/master.zip

ImprovedTube added a commit that referenced this issue Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants