-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask Vivaldi to fix side panels #2288
Comments
Same here, it seems to happen on Kleinanzeigen.de and certain reddit.com postings. (Uninstalled for now before really analyzing it) The annoying thing is that it also switches to that side panel. |
hi & thanks @thangcuoi @7eggert @raszpl so the icon re-appears in the side panel with every update? And it even opens itself @7eggert? For now you (or we) can also remove the side-panel declaration from our manifest.json. But generally it feels wrong that we keep doing things only for Vivaldi (or Opera GX). Vivaldi users are less than 1 in 1500 browser users. And ImprovedTube users are less than 1 in 1500 of YouTube users. Granted Vivaldi customization can raise productivity (and i don't know why Firefox would stop that). And thus there must be a more serious intersection in user-base. - And i just don't know if Vivaldi wants to stay a specific "Asperger niche with absolute opinions"? ( https://vivaldi.com/blog/why-vivaldi-will-never-create-thinkcoin/ - granted this is correctly describing majority of crypto currencies and activity. Yet some "only need a 100 servers and are empowering/paying bloggers, or so.) |
To make it all more silly, after waiting for chromium for ~15 years, to move side panels to the main releases 1 year ago, now it comes unreliable, with an increasing minimum width otherwise and requiring manifest 3. |
@ImprovedTube As Patrick mentioned, we're very open to more control over sizing - Chrome is a large product though and we need to align both within our team and with others. As a side note, we both try to keep an eye on discussions around the web on a best-effort basis, but the mailing list is definitely the best place to chat :) |
Yes, ImprovedTube keep adding itself to the side panel and open itself, in multiple tabs and windows. Side panel is a place for frequently access website. ImprovedTube (and most browser extension) does not belong there. It should stay hidden in the extension bar after initial configuration. ( Answer by @ImprovedTube: ) hi @thangcuoi, please report this to Vivaldi for not implementing it correctly. ("adding itself" is not the right wording. Only thing we can do is the trade-off, to remove/delay the option further for all, to wait for Vivaldi. ) |
hi! & thanks @oliverdunk, could be refined as min-width: min( 360px, calc(3vw+1vh)), if any. Chromium is the nr.1 browser & open source. Side-panels are made for extensions. And what else? So a non-configurable size can only say "Fail" or more specifically, "We still don't dare to let extensions be lean & integrate well into daily browsing but want to marginalize them"
Don't have permission to answer in the mail-group (as most of the times i otherwise might have reported or responded somewhere at groups.google)
Sorry, seems i didn't need to mention zoom, which might only occurred to us as of our html (and Jackie Han's too) |
@ImprovedTube can you elaborate? In what way do you "not have permission"? |
hi & thanks! @patrickkettner just noticed this group can be joined |
For me the problem manifests as follows: I open an offering on e.g. Kleinanzeigen.de, then the side bar opens and jumps to the IYT controls. There isn't even a video on that page. |
I noticed and reported this a week ago #2263 (comment) This is not a Vivaldi bug, Improvetube is the only extension doing this, something is wrong either in its Manifest-v3 json or in background.js |
something? @raszpl
|
I dont agree with your #2293 assessment https://developer.chrome.com/docs/extensions/reference/api/sidePanel Edit: I kept reading and 2293 author says the same thing #2293 (comment) this is NOT vivaldi bug |
hi @raszpl, then why does it only happen in one Browser and wasn't noticeable in our uninstall-/reinstall-count? & Why does removing "default_path" from the search for any sidepanel.html hardly increase the amount of results? https://github.com/search?q=sidepanel.html+language%3AJSON+default_path&type=code |
re any of those real extensions? I gave up after clicking 10 in a row and not being able to find one in google store. it force added itself in Chrome too, but Chrome sidepanel sucks making people click several times to open it |
install it it still forces itself into sidebar, author didnt understand documentation and misconfigured it |
Side panels open through a click by default. Defining a sidepanel.html doesn't strangely overpower an extension, it is just an alternative to the index.html. A side panel can only automatically be opened with sidePanel.open(), if ever |
*@raszpl 2293 was based on mood. Hope nothing decreases yours. |
ImprovedTube: Browser Sidepanel is off, but the extension keep adding itself to my Vivaldi's browser sidepanel.
I believe this has been happening with every recent version of ImprovedTube update, for the past 2 weeks.
The text was updated successfully, but these errors were encountered: