Hotkey for resolution change only works 50% of the time

[ballo]

Bug Report:

⚬ BUG: Hotkey to change the resolution to "Auto" doesn't trigger half the time and I don't know why
⚬ HOW:

1. Set the default video resolution to 144p
2. Set the hotkey 'a' to change the resolution to Auto
3. Load a Youtube video
4. Press 'a'

Sometimes it works, sometimes it doesn't. I haven't figured out the rhyme or reason why. Pressing 'a' several times doesn't seem to help. If it fails I have to select auto manually via the menu.

[Anoaxx]

Sometimes the player is unfocused somehow, and hotkeys dont work

[ballo]

Sometimes the player is unfocused somehow, and hotkeys dont work

Any workaround?

[Anoaxx]

try not to focus search bar or header? im not sure. Usually doing other things on page doesnt make that happen, at least for me

[ImprovedTube]

hi @ballo did it start only recently?

• might be related to the conditions here? (must be the reason unless all shortcuts fail.)
  

  youtube/content-scripts/website-context/youtube-features/shortcuts.js

  Lines 45 to 48 in df240ab

  	if (!ImprovedTube.isset(mouse.wheel) || mouse.wheel === 0 || mouse.player === true) {
  	if (same_keys === true) {
  	if ([
  	'shortcutAuto',

---

#1565

---

unfocused

thanks! @Anoaxx ( i dont know more this time yet but generally writing down exact experiences as soon as you make them,
can be half the work / speed up our development, if they are conclusive/as conclusive as possible. )

search bar

of course single hotkeys and input compete (must, unless using hotkeys that rarely appear in input)

[ballo]

Compete with what? Nothing uses 'a', and no text input box is ever the focus. All I'm doing is loading a new tab and pressing 'a'

Edit: youtube uses a lot of single letter hotkeys like 1-0, jkl, f, <>, etc.

[ImprovedTube]

hi @ballo did it start only recently?

• might be related to the conditions here? (must be the reason unless all shortcuts fail.)
  

  youtube/content-scripts/website-context/youtube-features/shortcuts.js

  Lines 45 to 48 in df240ab

  	if (!ImprovedTube.isset(mouse.wheel) || mouse.wheel === 0 || mouse.player === true) {
  	if (same_keys === true) {
  	if ([
  	'shortcutAuto',

[ballo]

I only recently started using the hotkey so I can't comment on if it ever worked correcty

[ballo]

It's so weird how when it fails, it can't be made to work. I click different areas and hover the cursor over different things and it just refuses to work.

[ballo]

I did an experiment replacing the hotkey with ctrl-a instead of just 'a'. I still get situations where the hotkey doesn't work. It's not the choice of the key or key combo that is the issue. The bug appears to be solely related to something grabbing focus and the extension never getting the key event.

[raszpl]

opening devtools and placing breakpoint on

youtube/content-scripts/website-context/youtube-features/shortcuts.js

Line 48 in df240ab

'shortcutAuto',

shows shortcut triggering every time no matter what , at least for me.
Switching to specific resolutions works immediately, switching to Auto takes couple of seconds when we are going from forced 144p, but doesnt work at all if we are trying to go to Auto from forced initial 1080p.
Extension is doing everything right, its YT player deciding to ignore be very slow? for Auto setting if currently playing resolution is close enough:

this.elements.player.getUserPlaybackQualityPreference()
'auto'
this.elements.player.getPlaybackQuality()
'hd1080'

If I pause in the debugger, sit there for a minute, and resume it does actually finally switch to Auto(720).

TLDR: we cant do anything about it, its YT Player doing its own things after being asked to switch to Auto.

[ballo]

You're switching to auto via elements, which you say isn't working, but when it doesn't work for me I can always do it manually by selecting "Auto" in the quality sub menu. What's the difference between the two?

[raszpl]

difference between the two

player menu calls youtube private function internally, all we have access to are
player.setPlaybackQualityRange(value);
player.setPlaybackQuality(value);

[ballo]

OK, well I guess I'll have to keep playing with it. Thanks for the help.

I don't suppose this is a bug that can be reported to Google

[ballo]

It seems to be working more consistently now. Did Google fix their site?

[ImprovedTube]

hi @ballo since today?

player menu calls youtube private function internally, all we have access to are
player.setPlaybackQualityRange(value);
player.setPlaybackQuality(value);

(Besides, without these, it wouldn't be the first time that we'd simulate user clicks.)

---

btw, several youtube-premium users kept asking for us to consider 1080 premium in the feature.

[raszpl]

could be also a shortcut bug like #2403
#2406 where all shortcuts stop working until reload or alt-tab

[ballo]

OK it works horribly now. Maybe it stops working when the cursor enters the view? I don't know how to make it work consistently :(

Edit: can't select auto to save my life. Selecting 1080p works maybe 50% of the time

[ballo]

Huh, trying to select auto instead selects 144p