Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload/schemachange: add COMMENT ON TYPE to random schemachange workload #123845

Open
rafiss opened this issue May 8, 2024 · 0 comments
Open

workload/schemachange: add COMMENT ON TYPE to random schemachange workload #123845

rafiss opened this issue May 8, 2024 · 0 comments
Assignees
@Dedej-Bergin
Labels
A-random-schema-change-workload C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations

Comments

@rafiss
Copy link
Collaborator

rafiss commented May 8, 2024 •
edited by cockroach-jira-scripts

The schemachange workload randomly generates schema change operations to run against a test cluster. It is a helpful way to test a large surface area without needing to manually write a lot of test code for different edge cases.

Since we are implementing the COMMENT ON TYPE syntax, we should add it to the workload.

Look at the change in fb02cd9, where other COMMENT operations were added. Extend the code so it also tests COMMENT ON TYPE.

Epic CRDB-37480

Jira issue: CRDB-38569
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) A-random-schema-change-workload labels May 8, 2024
@blathers-crl blathers-crl bot added this to Triage in SQL Foundations May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dedej-Bergin Dedej-Bergin

Labels
A-random-schema-change-workload C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations
  
Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafiss @Dedej-Bergin