sqlstats: requests for % of all Runtime in SQL Activity are incorrectly sorted by svcLatency
#123841
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-support
Originated from a customer
T-observability
Comments
dhartunian
added
C-bug
dhartunian
added
GA-blocker
branch-release-23.1
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this issue
May 8, 2024
Previously, when a request was made to the combined stats endpoint on CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort instead because of a missing switch case. This change fills that gap and adds some datadriven tests to inspect the resulting `WHERE` clauses. Fixes: cockroachdb#123841 Epic: CRDB-37544 Release note (ui change): Viewing SQL Activity sorted by `% of Runtime` now correctly sorts entries by the runtime amount.
dhartunian
removed
GA-blocker
branch-release-23.1
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this issue
May 8, 2024
Previously, when a request was made to the combined stats endpoint on CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort instead because of a missing switch case. This change fills that gap and adds some datadriven tests to inspect the resulting `WHERE` clauses. Fixes: cockroachdb#123841 Epic: CRDB-37544 Release note (ui change): Viewing SQL Activity sorted by `% of Runtime` now correctly sorts entries by the runtime amount.
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this issue
May 8, 2024
Previously, when a request was made to the combined stats endpoint on CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort instead because of a missing switch case. This change fills that gap and adds some datadriven tests to inspect the resulting `WHERE` clauses. Fixes: cockroachdb#123841 Epic: CRDB-37544 Release note (ui change): Viewing SQL Activity sorted by `% of Runtime` now correctly sorts entries by the runtime amount.
craig bot
pushed a commit
that referenced
this issue
May 9, 2024
123846: sqlstats: generate PCT_RUNTIME sort when requested r=xinhaoz a=dhartunian Previously, when a request was made to the combined stats endpoint on CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort instead because of a missing switch case. This change fills that gap and adds some datadriven tests to inspect the resulting `WHERE` clauses. Fixes: #123841 Epic: CRDB-37544 Release note (ui change): Viewing SQL Activity sorted by `% of Runtime` now correctly sorts entries by the runtime amount. 123891: status: fix possible index out of bounds in cpu sampling r=yuzefovich a=yuzefovich This commit fixes a possible index out of bounds crash that could previously occur when `cpu.Times` returned an error when sampling runtime stats. The bug was introduced in 4b9a337. Fixes: #120129. Release note: None Co-authored-by: David Hartunian <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
May 9, 2024
Previously, when a request was made to the combined stats endpoint on CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort instead because of a missing switch case. This change fills that gap and adds some datadriven tests to inspect the resulting `WHERE` clauses. Fixes: #123841 Epic: CRDB-37544 Release note (ui change): Viewing SQL Activity sorted by `% of Runtime` now correctly sorts entries by the runtime amount.
blathers-crl bot
pushed a commit
that referenced
this issue
May 9, 2024
Previously, when a request was made to the combined stats endpoint on CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort instead because of a missing switch case. This change fills that gap and adds some datadriven tests to inspect the resulting `WHERE` clauses. Fixes: #123841 Epic: CRDB-37544 Release note (ui change): Viewing SQL Activity sorted by `% of Runtime` now correctly sorts entries by the runtime amount.
blathers-crl bot
pushed a commit
that referenced
this issue
May 9, 2024
Previously, when a request was made to the combined stats endpoint on CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort instead because of a missing switch case. This change fills that gap and adds some datadriven tests to inspect the resulting `WHERE` clauses. Fixes: #123841 Epic: CRDB-37544 Release note (ui change): Viewing SQL Activity sorted by `% of Runtime` now correctly sorts entries by the runtime amount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
To Reproduce
Ran the
sqlstatsandmovrworkloads on a cluster, and then opened SQL Activity.Sorting by top 100 and top 500 produces inconsistent results:
Top 100
Top 500
Expected behavior
The top 100 entries in the top 500 view should be identical.
Environment:
Jira issue: CRDB-38567
Epic CRDB-37544
The text was updated successfully, but these errors were encountered: