Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements #376

Closed
wants to merge 1 commit into from
Closed

Performance improvements #376

wants to merge 1 commit into from

Conversation

seb86
Copy link
Member

@seb86 seb86 commented Apr 17, 2023

Description

This pull request will improve file dexterity and optimize CoCart for better performance.

Also improved field caching so responses are faster if the same information is requested again and again.

For developers, this improvement will make it easier to extend Schema and the cart update callback.

Results will vary but so far our benchmark tests have shown to have taken off between 1 to 2 and half seconds compared to the current stable release.

As the Pull Request is updated, notes will be added.

How has this been tested?

In Postman. Running the same requests over and over again.

To Do

  • Update performance per each endpoint.
  • Run API v2 without the need to extend API v1 (May end up doing in v5.0.0)
  • Deprecate API v1 if API v2 can run individually (May end up doing in v5.0.0)

Checklist:

  • Performance improvements for the Cart API is complete
  • Performance improvements for the Products API is complete
  • Performance improvements for the Session API is complete
  • I've added proper labels to this pull request

@seb86 seb86 added type: enhancement The issue is a request for an enhancement. refactor priority: critical The issue is critical—e.g. a fatal error, security problem affecting many customers. status: in progress This is being worked on. focus: shared API Issues related to all CoCart API overall. labels Apr 17, 2023
@seb86 seb86 added this to the v4.0 milestone Apr 17, 2023
@seb86 seb86 self-assigned this Apr 17, 2023
@seb86 seb86 modified the milestones: v4.0, v5 Apr 21, 2023
@seb86 seb86 mentioned this pull request Apr 21, 2023
Open
@seb86
Copy link
Member Author

seb86 commented Apr 21, 2023

Pushing this back to v5 milestone so we don't delay v4 any further.

@github-actions github-actions bot added status: stale Issues that have not had any activity for some time. category: refactor The issue/PR is related to refactoring. and removed scale:large labels Apr 21, 2023
@seb86 seb86 marked this pull request as ready for review May 6, 2023 15:24
@seb86 seb86 marked this pull request as draft May 6, 2023 15:25
@github-actions github-actions bot removed the status: stale Issues that have not had any activity for some time. label Nov 16, 2024
@seb86 seb86 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seb86 seb86

Labels
category: refactor The issue/PR is related to refactoring. focus: shared API Issues related to all CoCart API overall. priority: critical The issue is critical—e.g. a fatal error, security problem affecting many customers. status: in progress This is being worked on. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API v3 - Make extending easier
1 participant
@seb86