Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom go_package name, error #14

Open
sishui opened this issue Dec 30, 2022 · 1 comment · May be fixed by #16
Open

custom go_package name, error #14

sishui opened this issue Dec 30, 2022 · 1 comment · May be fixed by #16

Comments

@sishui
Copy link
Contributor

sishui commented Dec 30, 2022

Describe the bug

When the go_package name is customized, the generated pb.fast.go is wrong

Steps to reproduce the behavior:
custom go_package:

option go_package = "github.com/cloudwego/fastpb/examples/fastpb_gen/user/player;playercustom";

although the official documentation does not recommend this, but it is legal.
@sishui sishui mentioned this issue Dec 30, 2022
Closed
@HeyJavaBean
Copy link
Member

感谢反馈，我后续会看下这个问题以及你的pr。

@sishui sishui linked a pull request Feb 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

custom golang's pkg name sishui/fastpb
fix: custom golang's pkg name sishui/fastpb
2 participants
@sishui @HeyJavaBean