-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(aws,gcp,k8s,azure): Test caching in CI does not work #9388
Comments
I'll be introducing reusable workflows in #9518 to make the change easier. |
Desired outcomeEvery plugin test workflow should utilize build & test cache. Proposed solutionAdd build & test caching for every plugin build we have. Cache should be restored every time we do something Go-related (build, test, lint), and saved after testing from the default ( Additional stepsUse reusable workflowsWe can utilize reusable workflows to extract the repeating parts from plugin workflows.
This change is extracted into a separate #9655 issue. Update runner logicCurrently we use large runners for releases. The reason for this is to prime the build cache. However, this cache is only used during releases and I want to utilize large runners on the default ( |
After spending quite a bit of time reviewing and working on this issue, we realized The resolution is to use a separate cache key for those jobs, by disabling We've also submitted a PR to add support for this use case in I updated the issue title to reflect the conclusion, and will discuss re-usable workflows separately |
Which problem is this feature request solving?
Every time we update huge plugins (like AWS) we retest all pf the code instead of only testing the affected parts.
Describe the solution you'd like
Only testing the affected parts (need to make sure, though, that the libraries updates trigger the tests, too).
Possibly, this can be achieved by caching Go build cache & test cache (see this workflow as an example).
Relevant info:
https://pkg.go.dev/cmd/go#hdr-Build_and_test_caching
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows
https://github.com/marketplace/actions/cache
https://github.com/marketplace/actions/golang-with-cache
https://github.com/mvdan/github-actions-golang
Pull request (optional)
The text was updated successfully, but these errors were encountered: