Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): add a new workflow containing all checks #145

Merged
merged 10 commits into from
Jul 26, 2024

Conversation

andypf
Copy link
Collaborator

@andypf andypf commented Jul 24, 2024

Summary

This PR streamlines the CI workflow by consolidating separate checks into a single file. It optimizes the process by installing Node.js modules once and reusing them across multiple check jobs. This change improves efficiency and reduces redundancy in our CI checks.

Changes Made

  • Create new file ci-checks.yaml in .github/workflows
  • Use cache action to cach npm store
  • Use artifact action to upload and download node_modules
  • Define individual jobs for lint, license and test
  • Create a new file release.yaml containing tasks for publishing to npm

Related Issues

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@andypf andypf requested a review from a team as a code owner July 24, 2024 12:38
Copy link

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: d4f5653

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@andypf andypf requested a review from franzheidl as a code owner July 24, 2024 14:06
@andypf andypf force-pushed the andypf-ci-workflow branch 5 times, most recently from 0993801 to ee4aded Compare July 25, 2024 13:23
@andypf andypf force-pushed the andypf-ci-workflow branch from ee4aded to a270e6b Compare July 25, 2024 14:30
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

publish: npm run release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. new line

@andypf andypf merged commit d3dd6f7 into main Jul 26, 2024
6 of 7 checks passed
@andypf andypf deleted the andypf-ci-workflow branch July 26, 2024 07:34
@andypf andypf restored the andypf-ci-workflow branch September 5, 2024 14:44
@andypf andypf deleted the andypf-ci-workflow branch September 5, 2024 14:50
@andypf andypf restored the andypf-ci-workflow branch September 5, 2024 14:50
@andypf andypf deleted the andypf-ci-workflow branch September 5, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants