Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK](ui): Migrate ThemeToggle to Typescript #665

Closed
6 tasks done
Tracked by #168
guoda-puidokaite opened this issue Dec 5, 2024 · 0 comments
Closed
6 tasks done
Tracked by #168

[TASK](ui): Migrate ThemeToggle to Typescript #665

guoda-puidokaite opened this issue Dec 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@guoda-puidokaite
Copy link
Contributor

guoda-puidokaite commented Dec 5, 2024

Task Description

We need to convert ThemeToggle from @cloudoperators/juno-ui-components to TypeScript.

Sub-tasks

  • change the name to .tsx of all related components
  • Change the stories to .tsx and all related componetns
  • fix all errors related to npm run typecheck
  • Transfer all related tests to vitests from jest
  • Check if npm run build is working and prove the working parts in storybook or example app
  • Check that npm run lint is working correctly and fix all tslint errors

Related Issues

Additional Context
Please check this online codemode editor to change the PropTypes to a proper Ts interfaces

https://github.com/mskelton/ratchet
Online editor: https://ratchet.mskelton.dev/

We need to be pretty concious about migration to ts cause it could create a potential breaking changes. Also if there will be too much changes at once maybe consider to split up the task again. Also some dependencies could be hidden and only discovered while executing the migration, could also lead to potential reconsidering the order of task execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant