Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK](ui): Move deprecated components to deprecated_js after Typescript migrated components deleted #662

Closed
19 tasks done
Tracked by #168
guoda-puidokaite opened this issue Dec 5, 2024 · 0 comments · Fixed by #670
Closed
19 tasks done
Tracked by #168
Assignees
Labels
enhancement New feature or request

Comments

@guoda-puidokaite
Copy link
Contributor

guoda-puidokaite commented Dec 5, 2024

Task Description

After the Typescript migration is fully done and deprecated .js files have been deleted, move all left components that are deprecated to the deprecated_js folder.

Deprecated in Storybook (folder + description):

NOT deprecated in Storybook (folder + description):

  • AppIntro (converted to TS)

Sub-tasks

  • Move deprecated files to deprecated_js
  • Make sure all imports and exports correct
  • Make sure all deprecated components are marked as deprecated in Storybook (AppIntro)

Related Issues

Additional Context
Please check this online codemode editor to change the PropTypes to a proper Ts interfaces

https://github.com/mskelton/ratchet
Online editor: https://ratchet.mskelton.dev/

We need to be pretty concious about migration to ts cause it could create a potential breaking changes. Also if there will be too much changes at once maybe consider to split up the task again. Also some dependencies could be hidden and only discovered while executing the migration, could also lead to potential reconsidering the order of task execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant