Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task](ui): Change imports from deprecated Javascript components to Typescript (incl. Portal) and tidy up #645

Closed
6 of 8 tasks
Tracked by #168
guoda-puidokaite opened this issue Nov 29, 2024 · 1 comment · Fixed by #668
Closed
6 of 8 tasks
Tracked by #168
Assignees

Comments

@guoda-puidokaite
Copy link
Contributor

guoda-puidokaite commented Nov 29, 2024

Task Description

When all components in @cloudoperators/juno-ui-components have been migrated to Typescript, we should swap over any remaining deprecated imports to the new migrated ones. After all, delete all migrated Javascript components from deprecated_js.

List of potential dependencies

Sub-tasks

  • Make sure that all migrated components import Typescript components instead of deprecated Javascript ones (especially Portal and AppShellProvider).
  • Change index.js in AppShellProvider to index.ts.
  • Delete all migrated components from deprecated_js.
  • Check Storybook
  • Test Supernova, Elektra
  • Fix all errors related to npm run typecheck
  • Check if npm run build is working (note: errors already existed before, need to fix in another ticket)
  • Check that npm run lint is working correctly and fix all tslint errors

Related Issues

@guoda-puidokaite guoda-puidokaite changed the title [Task](context): Change imports from deprecated Javascript components to Typescript and tidy up [Task](ui): Change imports from deprecated Javascript components to Typescript and tidy up Nov 29, 2024
@guoda-puidokaite guoda-puidokaite self-assigned this Nov 29, 2024
@guoda-puidokaite guoda-puidokaite changed the title [Task](ui): Change imports from deprecated Javascript components to Typescript and tidy up [Task](ui): Change imports from deprecated Javascript components to Typescript (incl. Portal) and tidy up Dec 11, 2024
@guoda-puidokaite
Copy link
Contributor Author

Tested Supernova and Elektra Key Manager with @ArtieReus, focusing on Portal-related functionality

Supernova

  • Clicked on the "Silence" button from the alerts list and from the alert details view
    • then clicked on the silence duration dropdown to verify that everything is visible and stacked properly on top of each other
  • Checked that the Panel header is visible and doesn't disappear underneath the PageHeader
  • Scrolled down to make the content disappear underneath the PageHeader
Screenshot 2024-12-11 at 09 59 43 Screenshot 2024-12-11 at 10 02 08 Screenshot 2024-12-11 at 10 02 51

Elektra Key Manager

  • Opened a Panel to see that it opens correctly above the Elektra PageHeader
  • Tested the DateTimePicker
  • Tested Select
Screenshot 2024-12-11 at 09 55 22 Screenshot 2024-12-11 at 09 55 33 Screenshot 2024-12-11 at 09 55 55 Screenshot 2024-12-11 at 09 57 25

CC: @edda @barsukov @andypf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant