Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK](ui): Migrate Message component to TypeScript #238

Closed
7 tasks done
Tracked by #168
barsukov opened this issue Aug 16, 2024 · 1 comment · Fixed by #511
Closed
7 tasks done
Tracked by #168

[TASK](ui): Migrate Message component to TypeScript #238

barsukov opened this issue Aug 16, 2024 · 1 comment · Fixed by #511
Assignees
Labels
enhancement New feature or request

Comments

@barsukov
Copy link
Contributor

barsukov commented Aug 16, 2024

Task Description

We need to convert Message and all related components from @cloudoperators/juno-ui-components to TypeScript

List of potential dependencies

  • Check files that used with Message.

Sub-tasks

  • change the name to .tsx of all related components
  • Change the stories to .tsx and all related componetns
  • fix all errors related to npm run typecheck
  • Transfer all related tests to vitests from jest
  • Check if npm run build is working and prove the working parts in storybook or example app
  • Prove the working parts in storybook or example app
  • Check that npm run lint is working correctly and fix all tslint errors

Related Issues

Additional Context
Please check this online codemode editor to change the PropTypes to a proper Ts interfaces

https://github.com/mskelton/ratchet
Online editor: https://ratchet.mskelton.dev/

We need to be pretty concious about migration to ts cause it could create a potential breaking changes. Also if there will be too much changes at once maybe consider to split up the task again. Also some dependencies could be hidden and only discovered while executing the migration, could also lead to potential reconsidering the order of task execution.

@barsukov barsukov changed the title Message [TASK](ui): Migrate Message component to TypeScript Aug 16, 2024
@barsukov barsukov added the enhancement New feature or request label Aug 16, 2024
@guoda-puidokaite guoda-puidokaite self-assigned this Oct 9, 2024
@guoda-puidokaite guoda-puidokaite linked a pull request Oct 10, 2024 that will close this issue
6 tasks
@guoda-puidokaite guoda-puidokaite linked a pull request Oct 10, 2024 that will close this issue
6 tasks
@guoda-puidokaite
Copy link
Contributor

Bug Found 🐞

Issue: A timeout of less than one initiates a message auto-dismissal in Message
Description: During the Typescript migration it was found that a timeout of zero or a negative number causes an auto-timeout.
Fix: Fixed in the Typescript migration PR.

CC: @edda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants