-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authN): Refactor User Entity #85
Comments
You have sapID mentioned on multiple locations within the Project, having as a central unit the Entity and its filters: https://github.com/cloudoperators/heureka/blob/main/internal/entity/user.go#L11 This is as well present on the other Layers, e.g.: We need to rename those to uid. or uniqueUserId. @MR2011 What do you think is the more appropriate name? |
after internal discussion we aligned on uniqueUserId |
To prepare the Token Based Authentication and differentiation of Human users from Technical Users, please add as well the type property for a user, which should be an enum that accepts: "technical" and "user". The enum should be enforced on all layers (including the Database) |
@drochow What about UserFilter? Would you like to have entity.UserFilter to be extended for user type enum? |
Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and casual user Add gqlgen makefile target Add fmt makefile target
Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and casual user
Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and casual user
Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and casual user
Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and casual user
Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and human user
* feat(authN): change SapID to UniqueUserId (#85) Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and human user * Automatic application of license header --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: David Rochow <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]>
* feat(authN): change SapID to UniqueUserId (#85) Change name of variable SapId to UniqueUserId Add user Type variable to distinguish technical user and human user * Automatic application of license header --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: David Rochow <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]>
This issue is stale because it has been open for 90 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Remove SAP affiliations from the user attributes and make it Unique User ID
The text was updated successfully, but these errors were encountered: