Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authN): Refactor User Entity #85

Closed
Tracked by #7
lolaapenna opened this issue Jul 24, 2024 · 6 comments
Closed
Tracked by #7

feat(authN): Refactor User Entity #85

lolaapenna opened this issue Jul 24, 2024 · 6 comments

Comments

@lolaapenna
Copy link
Collaborator

lolaapenna commented Jul 24, 2024

Remove SAP affiliations from the user attributes and make it Unique User ID

@drochow
Copy link
Collaborator

drochow commented Jul 24, 2024

You have sapID mentioned on multiple locations within the Project, having as a central unit the Entity and its filters:

https://github.com/cloudoperators/heureka/blob/main/internal/entity/user.go#L11
https://github.com/cloudoperators/heureka/blob/main/internal/entity/user.go#L20

This is as well present on the other Layers, e.g.:
https://github.com/cloudoperators/heureka/blob/main/internal/database/mariadb/user.go#L19
https://github.com/cloudoperators/heureka/blob/main/internal/api/graphql/graph/schema/user.graphqls#L6

We need to rename those to uid. or uniqueUserId.

@MR2011 What do you think is the more appropriate name?

@drochow
Copy link
Collaborator

drochow commented Jul 24, 2024

after internal discussion we aligned on uniqueUserId

@drochow
Copy link
Collaborator

drochow commented Jul 24, 2024

To prepare the Token Based Authentication and differentiation of Human users from Technical Users, please add as well the type property for a user, which should be an enum that accepts: "technical" and "user". The enum should be enforced on all layers (including the Database)

@michalkrzyz michalkrzyz self-assigned this Jul 24, 2024
@michalkrzyz
Copy link
Collaborator

@drochow What about UserFilter? Would you like to have entity.UserFilter to be extended for user type enum?

michalkrzyz added a commit that referenced this issue Jul 29, 2024
Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and casual user
Add gqlgen makefile target
Add fmt makefile target
michalkrzyz added a commit that referenced this issue Jul 30, 2024
Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and casual user
@lolaapenna lolaapenna added this to the Heureka Access Control milestone Jul 31, 2024
michalkrzyz added a commit that referenced this issue Jul 31, 2024
Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and casual user
michalkrzyz added a commit that referenced this issue Jul 31, 2024
Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and casual user
michalkrzyz added a commit that referenced this issue Jul 31, 2024
Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and casual user
michalkrzyz added a commit that referenced this issue Jul 31, 2024
Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and human user
drochow added a commit that referenced this issue Aug 1, 2024
* feat(authN): change SapID to UniqueUserId (#85)

Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and human user

* Automatic application of license header

---------

Co-authored-by: License Bot <[email protected]>
Co-authored-by: David Rochow <[email protected]>
Co-authored-by: Michael Reimsbach <[email protected]>
dustindemmerle pushed a commit that referenced this issue Aug 6, 2024
* feat(authN): change SapID to UniqueUserId (#85)

Change name of variable SapId to UniqueUserId
Add user Type variable to distinguish technical user and human user

* Automatic application of license header

---------

Co-authored-by: License Bot <[email protected]>
Co-authored-by: David Rochow <[email protected]>
Co-authored-by: Michael Reimsbach <[email protected]>
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Oct 30, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants