Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Validation of Cluster name during onboarding #729

Closed
3 tasks done
IvoGoman opened this issue Nov 12, 2024 · 0 comments · Fixed by #785
Closed
3 tasks done

[FEAT] - Validation of Cluster name during onboarding #729

IvoGoman opened this issue Nov 12, 2024 · 0 comments · Fixed by #785
Assignees
Labels

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Nov 12, 2024

Priority

(Medium) I'm annoyed but I'll live

User Story

As a user I want to use greenhousectl validate the clusterName so that, I do not run into problems with bootstrapping a cluster with invalid name

Description

With #611 the Cluster webhook enforces a max length of 40 character for the name of the cluster and ensures that no -- may be included in the cluster name.

The greenhousectl should perform these validations as well, since the secret it will create is not validated. This means an invalid cluster name will result in the bootstrap controller failing to create the cluster.

The same validation should be added for the name of the kubeconfig secret, so that it ensures that a Cluster onboarded via greenhousectl or manually via secret has a valid name and can actually be created.

Acceptance Criteria

  • Validation of the 40 Char and no -- in the ClusterName
    • greenhousectl cluster boostrap enforces this
    • secret webhook for type greenhouse.sap/kubeconfig enforces this

Reference Issues

No response

@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Nov 12, 2024
@IvoGoman IvoGoman assigned IvoGoman and kengou and unassigned IvoGoman Nov 13, 2024
@kengou kengou linked a pull request Nov 27, 2024 that will close this issue
24 tasks
@github-project-automation github-project-automation bot moved this from Sprint Backlog to Done in Greenhouse Core Roadmap Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants