Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Refactor Team controller to store members in status #723

Open
2 tasks
IvoGoman opened this issue Nov 12, 2024 · 0 comments
Open
2 tasks

[FEAT] - Refactor Team controller to store members in status #723

IvoGoman opened this issue Nov 12, 2024 · 0 comments
Assignees
Labels

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Nov 12, 2024

Priority

None

User Story

As a Member of an Organization I can see the members of Teams in the status of a Team so that I do not have to know there are two resources.

Description

There are two CRDs that model a Team and it's Members (Team & TeamMembership).
The Team defines the upstream Group to be synced from SCIM. The TeamMembership contains the actual members of the Team. In terms of CRDs the Team is the Spec and the TeamMembership acts like the Status.

In order to simplify the controllers and to deprecate the TeamMembership controller in the future, the Team CRD should be extended so that it contains the Members in it's status.
For a brief period the Members will be stored in both, the Team's status and in the TeamMemberships Spec. After the Admin UI has been migrated to retrieve the TeamMembers from the Status we can deprecate and remove the TeamMembership controller.

The .Status for Team should contain the list of members that is also part of the .TeamMembership.Spec

Acceptance Criteria

  • TeamMembership controller stays as is
  • Team Controller updates the Team's status with the members retrieved from SCIM

Reference Issues

No response

@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Nov 12, 2024
@IvoGoman IvoGoman changed the title [FEAT] - <title> [FEAT] - Refactor Team controller to store members in status Nov 12, 2024
gciezkowski-acc added a commit that referenced this issue Dec 17, 2024
* feat(teams) Add members to team status (#723)

* Automatic generation of CRD API Docs

* Automatic application of license header

* feat(teams) Unit tests for members in team (#723)

* feat(teams) Team controller is running in team meme=bership tests (#723)

* Automatic application of license header

* Automatic generation of CRD API Docs

* feat(teams) Update unit test and update (#723)

* feat(teams) Add team controller responsibility to team membership updater (#723)

* Automatic application of license header

* feat(teams) Restore namespace selectors (#723)

---------

Co-authored-by: Cloud Operator <[email protected]>
Co-authored-by: License Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Sprint Backlog
Development

No branches or pull requests

2 participants