Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Organization is not cleaned up properly #700

Open
IvoGoman opened this issue Nov 6, 2024 · 0 comments
Open

🐛 [BUG] - Organization is not cleaned up properly #700

IvoGoman opened this issue Nov 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Nov 6, 2024

Priority

(Medium) I'm annoyed but I'll live

Description

As a admin I can delete an Organization so that the namespace and all resources are cleaned up accordingly.

The Organization is left hanging when it has been deleted. The EnsureDeleted requires that the Delete condition is set. Currently this is not the case.

Also the provisioned admin team cannot be deleted, as the propagation reconciler is left:

 finalizers:
  - greenhouse.sap/propagatedResource

The PropagationReconciler should not add the finalizer, if there are not clusters to propagate to. Also it should cleanup & remove the finalizer, once the propagated resource is being deleted.

Reproduction steps

1. Create an Organization
2. Wait until resources are created
3. Delete the Organization
4. Organization & all created resources including the namespace should be deleted

Manifests

apiVersion: greenhouse.sap/v1alpha1
  kind: ...

Screenshots

![DESCRIPTION](LINK.png)
@IvoGoman IvoGoman added the bug Something isn't working label Nov 6, 2024
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Sprint Backlog
Development

No branches or pull requests

1 participant