Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - Alerts Plugin regenerates CA on every diff #546

Open
IvoGoman opened this issue Dec 10, 2024 · 0 comments · Fixed by #549 · May be fixed by #559
Open

🐛 [BUG] - Alerts Plugin regenerates CA on every diff #546

IvoGoman opened this issue Dec 10, 2024 · 0 comments · Fixed by #549 · May be fixed by #559
Assignees
@richardtief
Labels
alerts Alerts Plugin - Alertmanager + Supernova UI bug Something isn't working observability

Comments

@IvoGoman
Copy link
Contributor

Priority

(Medium) I'm annoyed but I'll live

Description

The diff for the alerts plugin shows a diff for the ccloud-monitoring-ca and ccloud-ca-bundle on every reconciliation.

"Secret/ccloud-ca-bundle: [\n {\n \"value\": \"***** - after\",\n \"op\": \"replace\",\n \"path\": \"/data/ca.crt\"\n }\n],Secret/ccloud-monitoring-ca: [\n {\n \"value\": {\n \"apiVersion\": \"v1\",\n \"data\": {\n \"tls.crt\": \"*****\",\n \"tls.key\": \"*****\"\n },\n \"kind\": \"Secret\",\n \"metadata\": {\n \"annotations\": {\n \"helm.sh/hook\": \"pre-install, pre-upgrade\"\n },\n \"labels\": {\n \"app.kubernetes.io/managed-by\": \"Helm\",\n \"plugin\": \"alerts-ccloud\",\n \"plugindefinition\": \"alerts\",\n \"release\": \"alerts-ccloud\"\n },\n \"name\": \"ccloud-monitoring-ca\",\n \"namespace\": \"ccloud\"\n },\n \"type\": \"Opaque\"\n },\n \"op\": \"add\",\n \"path\": \"\"\n }\n]"}

The ccloud-monitoring-ca should not be regenerated on every deploy, but the condition does not work:
https://github.com/cloudoperators/greenhouse-extensions/blob/main/alerts/charts/templates/ca-secret-issuer-cert.yaml#L2

This causes reoccurring helm upgrades which eventually lead to the release stuck in pending.

Reproduction steps

1. Go to the organisation namespace 
2. `helm history alerts`
3. see frequent upgrades of the plugin

5239    	Tue Dec 10 17:43:41 2024	superseded	alerts-0.15.3	           	2.3.3
5240    	Tue Dec 10 17:44:49 2024	superseded	alerts-0.15.3	           	2.3.3
5241    	Tue Dec 10 17:45:55 2024	superseded	alerts-0.15.3	           	2.3.3
5242    	Tue Dec 10 17:47:02 2024	superseded	alerts-0.15.3	           	2.3.3
5243    	Tue Dec 10 17:48:08 2024	deployed  	alerts-0.15.3	           	2.3.3


### Screenshots

```bash
![DESCRIPTION](LINK.png)
@IvoGoman IvoGoman added the bug Something isn't working label Dec 10, 2024
@IvoGoman IvoGoman mentioned this issue Dec 10, 2024
Closed
@IvoGoman IvoGoman added alerts Alerts Plugin - Alertmanager + Supernova UI observability labels Dec 10, 2024
@richardtief richardtief self-assigned this Dec 11, 2024
@richardtief richardtief moved this from No status to In progress in Observability Roadmap Dec 11, 2024
@richardtief richardtief mentioned this issue Dec 11, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Observability Roadmap Dec 12, 2024
@richardtief richardtief reopened this Dec 18, 2024
richardtief added a commit that referenced this issue Dec 18, 2024
@richardtief
feat(alerts): improved ca cert generation
df837e3 
fixes: #546, #550
@richardtief richardtief linked a pull request Dec 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardtief richardtief

Labels
alerts Alerts Plugin - Alertmanager + Supernova UI bug Something isn't working observability
Projects
Observability Roadmap
Status: Done
Milestone
No milestone
2 participants
@IvoGoman @richardtief