Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump greenmail dependency #2673

Open
swalchemist opened this issue Jan 10, 2024 · 1 comment
Open

Bump greenmail dependency #2673

swalchemist opened this issue Jan 10, 2024 · 1 comment

Comments

@swalchemist
Copy link
Contributor

What version of UAA are you running?

76.29.0

What did you do?

UAA's dependabot.yml file blocks dependabot from upgrading com.icegreen:greenmail to version 2: Version 2+ was causing test flakiness, wait for it to stabilize. See https://github.com/cloudfoundry/uaa/pull/2314. When I tried version 2.0.1, the verifyThatBadUserAndBadPasswordCantSendMessages test failed, probably more because of breaking changes in the library than flakiness. We should try to get this test passing and see if any flakiness is still there in the library.

SmtpConfigurationTest > WithValidUsernameAndPassword > verifyThatBadUserAndBadPasswordCantSendMessages() FAILED
    java.lang.NoClassDefFoundError: jakarta/mail/MessagingException
        at org.cloudfoundry.identity.uaa.mail.SmtpConfigurationTest.setUp(SmtpConfigurationTest.java:34)
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186814417

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants