Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back lockfiles for bindings #198

Open
selfisekai opened this issue Nov 3, 2023 · 1 comment · May be fixed by #227
Open

bring back lockfiles for bindings #198

selfisekai opened this issue Nov 3, 2023 · 1 comment · May be fixed by #227

Comments

@selfisekai
Copy link

previously 9eb22a5 removed Cargo.lock files citing https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries.

this argumentation is valid for the library as used from another rust/cargo project, but the C API produces a binary rather than a library (from the text's standpoint). I think similar with the JS API too.

(aside, maybe this repository should use cargo workspaces)
@inikulin
Copy link
Contributor

inikulin commented Nov 28, 2023 •
edited
Loading

Good point. PR is welcome

it-a-me added a commit to it-a-me/lol-html that referenced this issue Sep 25, 2024
@it-a-me
Add lockfiles to language bindings
69fde6e 
Closes cloudflare#198
@it-a-me it-a-me linked a pull request Sep 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lockfiles to language bindings it-a-me/lol-html
2 participants
@inikulin @selfisekai