Duplicate by-method function

[danielbraun]

The by-method function is defined twice:

1. liberator/src/liberator/util.clj

   Line 51 in 1a2a510

   (defn by-method [& kvs]

2. liberator/src/liberator/core.clj

   Line 614 in b18447e

   (defn by-method

They behave differently:

• util/by-method: Accepts keyword arguments, returns nil if method wasn't defined
• core/by-method: Accept a map, return context if method wasn't defined. Due to deep merging of return values, all sequential values in the context are mutated. (Bad behavior, caused me a bug)

I assume the "better" one is util/by-method. Can we then at least deprecate the one in core?

[ordnungswidrig]

Good catch and sorry for not looking at this bug earlier. Can you describe the problem with core/by-method more detailed? I don't see where deep merging would kick in here. The functions seem similar to me except keyword args and handling of :any.

Maybe you could past an example or -- even better -- write a little test?