Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clojure-mode's test suite #25

Open
vemv opened this issue Oct 1, 2023 · 1 comment
Open

Run clojure-mode's test suite #25

vemv opened this issue Oct 1, 2023 · 1 comment
Assignees

Comments

@vemv
Copy link
Member

vemv commented Oct 1, 2023

As discussed in clojure-emacs/cider#3461, the https://github.com/clojure-emacs/clojure-mode/tree/master/test tests could be copied here, and then run in a CI matrix.

Note that although clojure-mode uses circleci, I'd recommend GHA more, these days.

Please use an Emacs and OS matrix similar to CIDER's.

Do feel free to disable tests that don't make sense here, or that can be left for later.

I'd suggest using the Eldev file to disable such tests, rather than deletion or commenting out. (That way one may be able to even git-clone clojure-test at a fixed tag, and run test/ verbatim).

Cheers - V

@dannyfreeman
Copy link
Contributor

I'm going to attempt to have these tests pulled into the repo in a way that preserves the history and contributors. I think I should be able to do something to the effect of:

  1. Fork clojure-mode
  2. re-write the history in such a way that only the tests folder is present in the repository.
  3. Add it as a remote to my local clojure-ts-mode repo.
  4. Create a merge commit between a clojure-mode commit and latest clojure-ts-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants