-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require a tag to function #9
Comments
I think it does now: https://github.com/cli/gh-extension-precompile/blob/trunk/build_and_release.sh#L21-L25 Probably can be closed now! :) |
The solution for this implemented in #21 breaks when the most recent tag is not on the commit that's checked out, and the checkout is shallow (which is the default behaviour of actions/checkout); this should probably be documented? |
This wasn't solved; that's the reason this issue is still open. Pushing a git tag is still required for this action to function. The idea is that it might be useful for this action to also have utility when activated on |
While it's ok to continue defaulting to running on a tag push, this extension should function without a tag and just use HEAD if run via a generic push or a workflow run trigger. (see discussion in #2 (comment) )
The text was updated successfully, but these errors were encountered: