-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Euler compare suggestions #166
Comments
Thanks! I opened a new PR with these changes.
Done.
It's the latter; I added an explanation.
Since this chapter is very different from all the rest, I've opted to show all the code. I added some text about this. I'm open to other suggestions.
I think this is a good idea but haven't done it yet. If you want to take a stab at it that would be great, or I may get to it in the next few days.
I added a link to the most recent Clawpack paper, which has references to lots of other helpful material. I don't want to try to turn this chapter into an explanation of all the stuff we've left out of this book, so I stopped there. Unfortunately, the blast wave problem with WENO5 leads to negative pressures unless you add a stronger limiter to enforce positivity. |
@ketch I took a look at Euler compare suggestions. I think the plots look really nice, and they show what we want to show. However, I think it would benefit from a bit more text and explanations.
I could help with some of this if you want.
The text was updated successfully, but these errors were encountered: