Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amount, pcode, ref_number, extra_infos #68

Open
noem6942 opened this issue Oct 8, 2021 · 4 comments
Open

amount, pcode, ref_number, extra_infos #68

noem6942 opened this issue Oct 8, 2021 · 4 comments

Comments

@noem6942
Copy link

noem6942 commented Oct 8, 2021

Proposals:

  • type(amount) should be float not str
  • rename pcode to postal_code as used in common
  • rename ref_number to reference_number (as in SIX documentation)
  • rename extra_infos to additional_information (as in SIX documentation)
  • implement Billing Information (to my understanding it's approved by 1.1.2021)
@claudep
Copy link
Owner

claudep commented Oct 15, 2021

Would you like to submit patches? In that case, please one change per commit (could be one or several pull requests). The last point probably deserves a separate issue.

@noem6942
Copy link
Author

Point 1 to 4 is trivial to implement without any backwards compatibility - but do you really want this?

@claudep
Copy link
Owner

claudep commented Oct 15, 2021

Sure, it looks like proper cleanup. It might be a bit less trivial if we want to keep compatibility with old names at entry points (script parameters and QRBill.__init__).

@bb1950328
Copy link

type(amount) should be float not str

this is a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants