Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detailed report message for GWS.CHAT.7 #279

Merged
merged 6 commits into from
May 16, 2024
Merged

Detailed report message for GWS.CHAT.7 #279

merged 6 commits into from
May 16, 2024

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented May 13, 2024

🗣 Description

Adds detailed report messages to GWS.CHAT.7.1 and GWS.CHAT.7.2. Additionally, corrects a bug with how DELETE_APPLICATION_SETTING events were handled for these settings.

💭 Motivation and context

Closes #210.

🧪 Testing

  • Updated unit tests
  • Make various tweaks in the admin center and verified the report was correct

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@adhilto adhilto added bug This issue or pull request addresses broken functionality enhancement labels May 13, 2024
@adhilto adhilto added this to the Barracuda milestone May 13, 2024
@adhilto adhilto requested review from rlxdev and buidav May 13, 2024 18:49
@adhilto adhilto self-assigned this May 13, 2024
@adhilto adhilto linked an issue May 13, 2024 that may be closed by this pull request
Detailed Report Message for GWS.CHAT.7.1 and GWS.CHAT.7.2 #210
Closed
@adhilto adhilto requested review from mitchelbaker-cisa and removed request for buidav May 14, 2024 20:29
mitchelbaker-cisa
mitchelbaker-cisa approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked that CHAT.7.1 fails if any of the conversations types are disabled.
  • Checked that CHAT.7.1 warns if any of the reporting categories are disabled.
  • All unit tests pass.

Looks good, left one small comment to fix.

rego/Chat.rego Outdated Show resolved Hide resolved
rlxdev
rlxdev approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@rlxdev rlxdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the minor typo fix included.

@adhilto adhilto merged commit f03374b into main May 16, 2024
2 of 3 checks passed
@adhilto adhilto deleted the 210-detailed-report-chat7 branch May 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlxdev rlxdev rlxdev approved these changes

@mitchelbaker-cisa mitchelbaker-cisa mitchelbaker-cisa approved these changes

Assignees

@adhilto adhilto

Labels
bug This issue or pull request addresses broken functionality enhancement
Projects
None yet
Milestone
Barracuda
Development

Successfully merging this pull request may close these issues.

Detailed Report Message for GWS.CHAT.7.1 and GWS.CHAT.7.2
3 participants
@adhilto @rlxdev @mitchelbaker-cisa