Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created markdown for removed policies for M365 #1090

Conversation

ahuynhMITRE
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE commented May 6, 2024

🗣 Description

This PR is to create the standard discontinued policy markdowns that will be utilized across M365 and GWS to track policies that have been discontinued, the date of discontinuation, and rationale behind discontinuation.

💭 Motivation and context

This change is required as a direct result of the conversations surrounding the continuous baseline update process to have a central markdown of removed/discontinued policies. This will remove any clutter in the baselines and assessment results.

closes #1016

🧪 Testing

ensure added markdown does not break current repository

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ahuynhMITRE ahuynhMITRE added the baseline-document Issues relating to the text in the baseline documents themselves label May 6, 2024
@ahuynhMITRE ahuynhMITRE added this to the Halibut milestone May 6, 2024
@ahuynhMITRE ahuynhMITRE self-assigned this May 6, 2024
@ahuynhMITRE ahuynhMITRE linked an issue May 6, 2024 that may be closed by this pull request
2 tasks
@ahuynhMITRE ahuynhMITRE force-pushed the 1016-create-template-markdown-for-discontinued-policy-ids-for-m365-gws branch from 0f353ee to 339d909 Compare May 6, 2024 20:39
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things to think about:

PowerShell/ScubaGear/baselines/Discontinued Policies.md Outdated Show resolved Hide resolved
PowerShell/ScubaGear/baselines/Discontinued Policies.md Outdated Show resolved Hide resolved
PowerShell/ScubaGear/baselines/Discontinued Policies.md Outdated Show resolved Hide resolved
PowerShell/ScubaGear/baselines/Discontinued Policies.md Outdated Show resolved Hide resolved
PowerShell/ScubaGear/baselines/Discontinued Policies.md Outdated Show resolved Hide resolved
PowerShell/ScubaGear/baselines/Discontinued Policies.md Outdated Show resolved Hide resolved
@adhilto
Copy link
Collaborator

adhilto commented May 7, 2024

I would also recommend we edit the baselines/README.md file to include a pointer to this new file.

@ahuynhMITRE
Copy link
Collaborator Author

I would also recommend we edit the baselines/README.md file to include a pointer to this new file.

good catch, will update!

Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ahuynhMITRE
Copy link
Collaborator Author

@nanda-katikaneni good to merge

@nanda-katikaneni nanda-katikaneni merged commit 23113c8 into main May 15, 2024
14 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1016-create-template-markdown-for-discontinued-policy-ids-for-m365-gws branch May 15, 2024 14:00
@ahuynhMITRE ahuynhMITRE changed the title 1016 create template markdown for discontinued policy ids for m365 & gws Created markdown for removed policies for M365 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create template markdown for discontinued policy IDs for M365 & GWS
4 participants